Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the year from 2019 to 2020 in the Copyright #32

Merged

Conversation

mrjerryjohns
Copy link
Collaborator

@mrjerryjohns mrjerryjohns commented Jan 28, 2020

Without this, all the PR build validations are failing...

Copy link
Contributor

@gerickson gerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAK. This should be "2019-2020".

codegen copyright emission logic to correctly bookend Google.
@mrjerryjohns mrjerryjohns force-pushed the feature/update-copyright-year branch from 94d4ac9 to c2a5057 Compare January 28, 2020 00:26
Copy link
Contributor

@gerickson gerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the 2018s need to be "2018-2020" rather than "2018-2019-2020".

.travis/before_install.sh Outdated Show resolved Hide resolved
Force installation of protoc when there is a mis-match in version.
Copy link
Member

@robszewczyk robszewczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to claim copyright on files that have not been modified in 2020. In Weave we have adopted a pattern to modify the copyright date when the files are touched.

@mrjerryjohns mrjerryjohns force-pushed the feature/update-copyright-year branch 2 times, most recently from 29fdd9d to f12344e Compare January 30, 2020 00:42
This replaces the use of easy_install to setup virtualenv with pip since
the former seems to give Github the fits with more recent versions of
virtualenv - It starts failing installing some of the dependent packages of virtualenv
(zipp, see libretime/libretime#952). Even putting that
workaround in isn't sufficient, as other failures ensue. Using pip seems to be
the more modern way of setting up virtualenv, so follow the masses if it ain't causing issues.
@mrjerryjohns mrjerryjohns force-pushed the feature/update-copyright-year branch from 563201b to f672628 Compare January 30, 2020 19:32
@mrjerryjohns mrjerryjohns merged commit 090b46a into openweave:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants