Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fdir from 6.4.0 to 6.4.2 #1896

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 17, 2024

Bumps fdir from 6.4.0 to 6.4.2.

Release notes

Sourced from fdir's releases.

v6.4.2

Fixes

  1. Fix regression where fdir would never resolve when maxDepth was set to < 0 (#127)

v6.4.1

Fixes

Recursive symlinks handling (#125)

Previously, fdir left it up to the OS to handle recursive symlinks. Unfortunately, this resulted in an infinite loop that'd either cause a crash or take too long to resolve (each OS has a different limit on resolving recursive symlinks). This has been fixed now in #126.

Recursive symlinks with resolvePaths: true

When resolvePaths is set to true, fdir does not crawl a directory it has already visited. To figure out whether we have visited a directory or not, fdir maintains a list of all the directories it has visited. This might result in slightly higher memory usage than before.

For a directory that looks like this:

/dir/
  file
  symlink -> /dir/

fdir will return:

[ "/dir/file" ]

In short, you won't see duplicated paths in the output which is the expected behavior when working with file systems since paths are unique.

Recursive symlinks with resolvePaths: false

When you set resolvePaths to false, the behavior differs because now all symlinks become part of the path.

For a directory that looks like this:

/dir/
  file
  symlink -> /dir/

fdir will return:

[ "/dir/file", "/dir/symlink/file" ]

To prevent recursion, all recursive symlinks are only resolved a single level deep making sure you never see something like /dir/symlink/symlink/symlink/file. This allows for glob patterns to work with recursive symlinks without creating a performance issue.

... (truncated)

Commits
  • 8288d39 chore: bump version to 6.4.2
  • abeacfb fix: fdir never resolves when maxDepth < 0 (fixes #127)
  • e17009b 6.4.1
  • 5d17127 test: add more tests for recursive symlinks
  • 6e3233a fix: recursive symlinks with relative paths not working
  • d8d2937 test: add tests for resolving recursive symlinks
  • a492652 fix: simplify recursion detection algorithm
  • 4525784 test: refactor symlink tests to separate file
  • 243dec6 fix: handle recursive symlinks
  • 2d1c558 test: formatting
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @gooborgstudios-bot.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [fdir](https://github.com/thecodrr/fdir) from 6.4.0 to 6.4.2.
- [Release notes](https://github.com/thecodrr/fdir/releases)
- [Commits](thecodrr/fdir@v6.4.0...v6.4.2)

---
updated-dependencies:
- dependency-name: fdir
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 17, 2024
@queengooborg queengooborg temporarily deployed to mdn-bcd-collector-pr-1896 October 17, 2024 11:37 Inactive
Copy link
Collaborator

@gooborgstudios-bot gooborgstudios-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot dependabot bot merged commit e9b33b4 into main Oct 17, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/fdir-6.4.2 branch October 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants