Skip to content
This repository has been archived by the owner on Jul 9, 2020. It is now read-only.

[Config] get rid of monkey patching in sortedm2m #29

Closed
nemesifier opened this issue Feb 14, 2017 · 7 comments
Closed

[Config] get rid of monkey patching in sortedm2m #29

nemesifier opened this issue Feb 14, 2017 · 7 comments
Labels
enhancement
Milestone
0.6

Comments

@nemesifier
Copy link
Member

Improve the change implemented in 96f4d09 by supplying a patch to django-sortedm2m, see jazzband/django-sortedm2m#96.
@nemesifier nemesifier added this to the 0.6 milestone Feb 14, 2017
@nemesifier
Copy link
Member Author

@rohithasrk. This issue is an interesting one.

@rohithasrk
Copy link
Contributor

Yeah. Will look into it.

@nemesifier
Copy link
Member Author

ok @rohithasrk it would be great if you could solve this. It's an interesting challenge. If you can't work on it let me know, I will have to do this soon because it's causing me to duplicate some code and I don't like this.

@rohithasrk
Copy link
Contributor

I see. Will try solving it ASAP.

@nemesifier nemesifier mentioned this issue Mar 6, 2017
Closed
@rohithasrk
Copy link
Contributor

rohithasrk commented Mar 17, 2017 •
edited
Loading

@nemesisdesign : Made a PR #101 in django-sortedm2m. Please review it.

@nemesifier
Copy link
Member Author

@rohithasrk great, replied there

nemesifier added a commit that referenced this issue Apr 21, 2017
@nemesifier
[qa] Moved sortedm2m__str__ to base models
47b7009 
References #29
@nemesifier
Copy link
Member Author

Now we can finally upgrade the django-sortedm2m to be higher or equal to 1.5.0 and remove the monkey patching :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@nemesifier @rohithasrk