Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Fix hardcoded storage class for private storage #195

Closed
nemesifier opened this issue Jun 7, 2022 · 0 comments · Fixed by #196
Closed

[bug] Fix hardcoded storage class for private storage #195

nemesifier opened this issue Jun 7, 2022 · 0 comments · Fixed by #196
Labels
bug Something isn't working

Comments

@nemesifier
Copy link
Member

This code makes it impossible to configure a different storage class (eg: object storage, Amazon S3) for the private storage files:

openwisp-firmware-upgrader/openwisp_firmware_upgrader/base/models.py

Lines 183 to 185 in e166999

storage=PrivateFileSystemStorage(
base_url=urljoin(FIRMWARE_API_BASEURL, IMAGE_URL_PATH)
),

@nemesifier nemesifier mentioned this issue Jun 7, 2022
Closed
@nemesifier nemesifier added the bug Something isn't working label Jun 7, 2022
pandafy added a commit that referenced this issue Jun 8, 2022
@pandafy
[fix] Made private storage backend configuration #195
6894323 
Added OPENWISP_FIRMWARE_PRIVATE_STORAGE_INSTANCE setting
to configure an instance of private storage class.

Fixes #195
@pandafy pandafy mentioned this issue Jun 8, 2022
Merged
pandafy added a commit that referenced this issue Jun 8, 2022
@pandafy
[fix] Made private storage backend configuration #195
2e3f4ce 
Added OPENWISP_FIRMWARE_PRIVATE_STORAGE_INSTANCE setting
to configure an instance of private storage class.

Fixes #195
pandafy added a commit that referenced this issue Jun 9, 2022
@pandafy
[fix] Made private storage backend configuration #195
17d0f83 
Added OPENWISP_FIRMWARE_PRIVATE_STORAGE_INSTANCE setting
to configure an instance of private storage class.

Fixes #195
nemesifier pushed a commit that referenced this issue Jun 10, 2022
@pandafy
[fix] Made private storage backend configuration #195
32e516e 
Added OPENWISP_FIRMWARE_PRIVATE_STORAGE_INSTANCE setting
to configure an instance of private storage class.

Fixes #195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenWISP Contributor's Board
Archived in project
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Made private storage backend configuration #195 openwisp/openwisp-firmware-upgrader
1 participant
@nemesifier