Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add user preferred language field #261 #297

Merged
merged 6 commits into from
Nov 26, 2021
Merged

[feature] Add user preferred language field #261 #297

merged 6 commits into from
Nov 26, 2021

Conversation

codesankalp
Copy link
Member

Closes #261

@codesankalp codesankalp force-pushed the issue/261-user-preferred-lang branch from d4a65da to 915a23f Compare November 15, 2021 08:33
@codesankalp codesankalp self-assigned this Nov 15, 2021
@coveralls
Copy link

coveralls commented Nov 15, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.726% when pulling a7e5d32 on issue/261-user-preferred-lang into 993f7ee on master.

nemesifier
nemesifier requested changes Nov 16, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see my request below.

openwisp_users/base/models.py Outdated Show resolved Hide resolved
nemesifier
nemesifier reviewed Nov 17, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I need to do some manual testing.

@nemesifier nemesifier merged commit 685ece8 into master Nov 26, 2021
@nemesifier nemesifier deleted the issue/261-user-preferred-lang branch November 26, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@codesankalp codesankalp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Add user preferred language field
3 participants
@codesankalp @coveralls @nemesifier