-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qa] Commit message check fails if there's a dot after the issue #187
Comments
Can I do this issue |
Sure @keshavgbpecdelhi go ahead |
@devkapilbansal can you tell were to do changes (which code required modification) |
I think you need to fix this function openwisp-utils/openwisp_utils/qa.py Line 83 in 1f73cc3
I tried looking at that issue and found that regex is returning |
Do we have to add "." in the skip case? |
It is written not to add "." openwisp-utils/openwisp_utils/qa.py Line 108 in 1f73cc3
|
It is for short description only |
@keshavgbpecdelhi did you tried going throigh the code once and undertand what's going there ? The best way to fix the error is to try reproduce it locally, see which part of code is responsible for that, writing a test case that will fail for sure unless the error is fixed and then solving the error. |
@keshavgbpecdelhi first step is to write a failing test to replicate the issue, see https://github.com/openwisp/openwisp-utils/blob/master/tests/test_project/tests/test_qa.py#L79-L135. |
Fix commit message check is failing when there is a dot after issue Closes #187.
Fix commit message check is failing when there is a dot after issue Closes #187.
Fix commit message check is failing when there is a dot after issue Closes #187.
Fix commit message check is failing when there is a dot after issue Closes #187.
Fix commit message check is failing when there is a dot after issue Closes #187.
Fix commit message check is failing when there is a dot after issue Closes #187.
Fix commit message check is failing when there is a dot after issue Closes #187.
Eg:
Closes #344.
: https://github.com/openwisp/openwisp-controller/runs/2529479318The text was updated successfully, but these errors were encountered: