-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qa] Add commit message style check #20
Labels
Comments
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 21, 2018
it's not clear. |
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 22, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 27, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 27, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 27, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 27, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 27, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 27, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
ppabcd
added a commit
to ppabcd/openwisp-utils
that referenced
this issue
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's time to automate the commit message style checks according to our guidelines, that will make contributing a lot smoother for new contributors and less time consuming for reviewers.
These are the most common issues which we should address:
Done something
(should be[qa] Done something
)[qa] done something
[qa] Done something.
Implements #20
(won't close),Closes #20 and #21
(won't close#21
- but we should allow writing something likeRelated to #33
, because sometimes we may want to reference an issue even though we are not solving it in that commitshould be:
(easier to read in the short log format)
This is not urgent but not unimportant because having a clean commit history is important for the long term sustainability of the project.
It doesn't make sense to keep enforcing these rules by hand.. it's clear to me that as the community grows we won't be able to do that, so automating this check is key.
We need something like the migration check implemented in #16.
The text was updated successfully, but these errors were encountered: