Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow geppetto Menu close event to be controlled #259

Closed
rodriguez-facundo opened this issue May 21, 2020 · 0 comments · Fixed by #226
Closed

Allow geppetto Menu close event to be controlled #259

rodriguez-facundo opened this issue May 21, 2020 · 0 comments · Fixed by #226
Assignees
@rodriguez-facundo
Labels
enhancement New feature or request
Milestone
Release 2.3.0

Comments

@rodriguez-facundo
Copy link
Member

We need a way to close the Menu component in response to zoom, scroll, right click events on other part of the application.
When we have drag events in a canvas and we prevent event propagation, the menu won't close.
@rodriguez-facundo rodriguez-facundo added the enhancement New feature or request label May 21, 2020
@rodriguez-facundo rodriguez-facundo self-assigned this May 21, 2020
rodriguez-facundo pushed a commit that referenced this issue May 21, 2020
#259 Allow Menu close event to be controlled
0d322a5
rodriguez-facundo pushed a commit that referenced this issue May 21, 2020
#259 Rename Close prop in Menu to Open
5872bfb
@rodriguez-facundo rodriguez-facundo mentioned this issue May 22, 2020
Merged
@filippomc filippomc linked a pull request May 22, 2020 that will close this issue
Cumulative #225 #228 #239 #242 #243 #259 #226
Merged
tarelli added a commit that referenced this issue May 26, 2020
@tarelli
Merge pull request #226 from openworm/feature/225
d933369 
Cumulative #225 #228 #239 #242 #243 #259
@filippomc filippomc added this to the Release 2.3.0 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodriguez-facundo rodriguez-facundo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 2.3.0
Development

Successfully merging a pull request may close this issue.

Cumulative #225 #228 #239 #242 #243 #259 openworm/geppetto-client
2 participants
@rodriguez-facundo @filippomc