Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional icon to close Querybuilder/ControlPanel/Spotlight #176

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Optional icon to close Querybuilder/ControlPanel/Spotlight #176

merged 1 commit into from
Feb 4, 2020

Conversation

ddelpiano
Copy link
Contributor

this close #175 .

@ddelpiano ddelpiano self-assigned this Feb 3, 2020
@ddelpiano ddelpiano added the enhancement New feature or request label Feb 3, 2020
filippomc
filippomc reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements with the process and description, we can do better though! The project kanban has to be updated - the issue and the PR should be in the "review" column.

js/components/interface/query/query.less Show resolved Hide resolved
@ddelpiano ddelpiano requested a review from filippomc February 3, 2020 14:23
@gidili gidili merged commit 0e4e5b0 into development Feb 4, 2020
@ddelpiano ddelpiano deleted the feature/175 branch June 30, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc filippomc approved these changes

@Robbie1977 Robbie1977 Robbie1977 approved these changes

@gidili gidili gidili approved these changes

Assignees

@ddelpiano ddelpiano

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddelpiano @gidili @Robbie1977 @filippomc