Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/280: Remove SPOTLIGHT_HINT and its timer #281

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Feature/280: Remove SPOTLIGHT_HINT and its timer #281

merged 1 commit into from
Jun 12, 2020

Conversation

tarelli
Copy link
Member

@tarelli tarelli commented Jun 5, 2020

Closes #280

@tarelli tarelli requested a review from rodriguez-facundo June 5, 2020 15:19
@tarelli tarelli requested a review from filippomc June 12, 2020 22:36
@tarelli
Copy link
Member Author

tarelli commented Jun 12, 2020

@filippomc @rodriguez-facundo do you guys think we can merge this?

rodriguez-facundo
rodriguez-facundo approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@rodriguez-facundo rodriguez-facundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have any problem with it. Tested it pulling in big models

@tarelli tarelli merged commit 10f3b5b into development Jun 12, 2020
filippomc
filippomc reviewed Jun 13, 2020
View reviewed changes
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that message is quite annoying!

@filippomc filippomc deleted the feature/280 branch June 26, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc filippomc left review comments

@rodriguez-facundo rodriguez-facundo rodriguez-facundo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarelli @rodriguez-facundo @filippomc