Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshot feature #843

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Screenshot feature #843

merged 2 commits into from
Dec 4, 2018

Conversation

jrmartin
Copy link
Contributor

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

Adds library for taking screenshots

@tarelli tarelli added the review label Oct 24, 2018
@tarelli tarelli changed the base branch from development to master December 4, 2018 16:37
@tarelli tarelli changed the base branch from master to development December 4, 2018 16:37
@jrmartin jrmartin changed the base branch from development to npm-gl-fix December 4, 2018 16:40
@jrmartin jrmartin changed the base branch from npm-gl-fix to development December 4, 2018 16:40
@tarelli tarelli merged commit 48d889d into development Dec 4, 2018
@tarelli tarelli deleted the screenshot-feature branch January 18, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrmartin @tarelli