Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling external severing of connection. #855

Merged
merged 1 commit into from
Nov 27, 2018
Merged

handling external severing of connection. #855

merged 1 commit into from
Nov 27, 2018

Conversation

Robbie1977
Copy link
Contributor

Need to trigger GEPPETTO.Events.Websocket_disconnected when severed by external actors.

Ref VirtualFlyBrain/geppetto-vfb#290

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

@Robbie1977 Robbie1977 merged commit e688276 into feature/react_refactoring-virgo Nov 27, 2018
@tarelli tarelli deleted the feature/react_refactoring-virgo-fixes branch January 18, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmartin jrmartin Awaiting requested review from jrmartin

@ddelpiano ddelpiano Awaiting requested review from ddelpiano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Robbie1977