Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pom.xml to scala component #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imagejan
Copy link

@imagejan imagejan commented Oct 5, 2018

This PR add a pom.xml to be able to build the scala component with maven. It would make it possible to easily deploy to a Maven repository, where other Maven-based projects can use it.

(this required moving the examples into src/test/scala/examples)

If this is acceptable, let me know if I should update the <developers> and <contributors> section according to the team role definitions.

This requires moving the examples into src/test/scala/examples

By using pom-scijava as a parent POM, we can easily deploy to Maven Central or to maven.imagej.net in the future.
@Ichoran
Copy link
Contributor

Ichoran commented Oct 6, 2018

Thanks! I'll review the PR shortly, but note that maven is an unusual choice for a build tool for Scala (sbt is typical), so I'm likely to take the details and port them to sbt instead to avoid requiring people to use multiple sets of tools to accomplish what can be done with one tool. (On the other hand, getting sbt to publish successfully is a bit of work; if the maven thing is substantially easier, maybe that's the way to go.)

@imagejan
Copy link
Author

imagejan commented Oct 8, 2018

I chose maven just because I'm not so familiar with sbt and scala, but re-using the maven setup from pom-scijava helped me to get a deployable jar file without a hassle. Any other mechanism is fine of course, my main intent was to make this usable from Maven-based Java projects simply by adding something like:

<dependency>
    <groupId>org.openworm<groupId>
    <artifactId>tracker-commons<artifactId>
</dependency>

@Ichoran
Copy link
Contributor

Ichoran commented Oct 8, 2018

@imagejan - However we handle the logistics, having an artifact published on Maven would be great. I'll try to get it up this week. (I usually end up struggling with Sonatype for a good while before I get anything published, though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants