Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger topo change on every link up after link down #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wryun
Copy link

@wryun wryun commented Sep 30, 2024

This causes DHCP renewals to happen when you disconnect/reconnect cables or re-establish wifi connections on a bridge.

I suspect I haven't done this in the right way - i.e. there's some implication I'm missing from causing TOPO_CHANGE all the time, though the 'auth' code does it anyway. But it's very useful for us in two situations:

  • if we have an AP device (i.e. bridging ethernet and AP), then it means if you disconnect/reconnect the ethernet link it will request a new address (behaving in the way people would expect).
  • if we have an Extender style device (i.e. bridging ethernet and STA), then if the STA link goes does it re-requests. Why is this useful? Because the AP might have reconfigured itself in some way; in our case, switching from a router (forwarding from AP->WAN) to an AP with ethernet bridged, in which case the DHCP server available will have changed. It's also useful in the case that the AP has reset if the AP is a DHCP server, in which case its DHCP lease table will have been cleared so it's nice from a UI perspective to have the STA renew.

This causes DHCP renewals to happen when you disconnect/reconnect
cables or re-establish wifi connections on a bridge.

Signed-off-by: James Haggerty <james.haggerty@morsemicro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant