Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediatek: Fixed phy6 DTS settings #17430

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

RolandoMagico
Copy link
Contributor

@RolandoMagico RolandoMagico commented Dec 30, 2024

Settings for phy6 can be simplified in the DTS

@github-actions github-actions bot added the target/mediatek pull request/issue for mediatek target label Dec 30, 2024
@aiamadeus
Copy link
Contributor

Is your device wireless not working?
Usually only ax3000/ax4200 devices need DBDC pins.

@RolandoMagico
Copy link
Contributor Author

Is your device wireless not working? Usually only ax3000/ax4200 devices need DBDC pins.

Wifi was already working before. I just compared the DTS with OEM and similar devices and saw that it is present. So if it’s not required, I can close the PR

@aiamadeus
Copy link
Contributor

So if it’s not required, I can close the PR

The DBDC pins are not required. But I noticed something else:

		phy6: phy@6 {
			compatible = "maxlinear,gpy211", "ethernet-phy-ieee802.3-c45";
			reg = <6>;
			phy-mode = "2500base-x";
		};

Can you try this to see if it works fine?

		phy6: phy@6 {
			compatible = "ethernet-phy-ieee802.3-c45";
			reg = <6>;
		};

@RolandoMagico
Copy link
Contributor Author

RolandoMagico commented Jan 2, 2025

Can you try this to see if it works fine?

Yes, seems to work as well. Currently I'm only able to test 1G wan link, tomorrow I can check with 2.5G

Update: Works with 1G and 2.5G

@aiamadeus
Copy link
Contributor

So you can change this pr to 2.5G phy typo fix.

@RolandoMagico RolandoMagico changed the title mediatek: Add DBDC pins for D-Link M60 mediatek: Fixed phy6 DTS settings Jan 6, 2025
@RolandoMagico RolandoMagico force-pushed the M60-DBDC branch 2 times, most recently from 6b474a9 to e579176 Compare January 6, 2025 07:38
Settings for phy6 can be simplified in the DTS

Signed-off-by: Roland Reinl <reinlroland+github@gmail.com>
Link: openwrt#17430
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
@openwrt-bot openwrt-bot merged commit 0d15682 into openwrt:main Jan 12, 2025
3 checks passed
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request Jan 18, 2025
Settings for phy6 can be simplified in the DTS

Signed-off-by: Roland Reinl <reinlroland+github@gmail.com>
Link: openwrt#17430
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
kimocoder pushed a commit to kimocoder/openwrt that referenced this pull request Jan 20, 2025
Settings for phy6 can be simplified in the DTS

Signed-off-by: Roland Reinl <reinlroland+github@gmail.com>
Link: openwrt#17430
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
KGeri201 pushed a commit to KGeri201/openwrt that referenced this pull request Jan 24, 2025
Settings for phy6 can be simplified in the DTS

Signed-off-by: Roland Reinl <reinlroland+github@gmail.com>
Link: openwrt#17430
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/mediatek pull request/issue for mediatek target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants