prometheus-node-expoter-lua: Add optout for metrics of unused interfaces #25241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Markouski <markalex2209@gmail.com>
|
It's an alternative solution to issue #22946. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @champtar
Compile tested: mips/MediaTek MT7621, Xiaomi Redmi Router AC2100, OpenWrt 23.05.0
Run tested: mips/MediaTek MT7621, Xiaomi Redmi Router AC2100, OpenWrt 23.05.0 (run with enabled and disable opt-out, checked absence of impact on scrape duration)
Description:
Added option
skip_unused_interfacesto configuration of prometheus-node-expoter-lua. By default disabled.When enabled
netdev.luacollector skips interfaces with all counters at 0.