Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.05] netatalk: Update to 4.0.4 (backport) #25262

Open
wants to merge 4 commits into
base: openwrt-23.05
Choose a base branch
from

Conversation

APCCV
Copy link
Contributor

@APCCV APCCV commented Nov 7, 2024

Maintainer: Antonio Pastor / @APCCV
Compile tested: ipq806x SDK (23.05.3, snapshot)
Run tested: ipq806x - C2600: start server, connect from MacOS, read/write files to home share, create/update TimeMachine backups. File sharing from MacOS 9.2.

Description: Backport of Netatalk to 23.05. Cherry-picked commits:

  • 645b04c: update to 3.2.0 restore from abandoned packages
  • be5ca7d: update to 3.2.5
  • d0abe3d: update to 4.0.4 using meson build
  • 049a055: Makefile cleanup for 4.0.4

NOT backporting these two commits.

  • 09a2427: AppleTalk feature on 4.0.4
  • 07efd50: glib2 dependency fix for 4.0.4

@APCCV
Copy link
Contributor Author

APCCV commented Nov 7, 2024

Hmmm.... @Neustradamus we might be too late for this (is 23.05 is still being built?)
Hopefully the failed checks are just due to buildbot upgrades and this can still be backported. This would provide netatalk on stable build.

@APCCV APCCV changed the title netatalk: Update to 4.0.4 (backport) [23.05] netatalk: Update to 4.0.4 (backport) Nov 7, 2024
@APCCV APCCV marked this pull request as draft November 7, 2024 15:33
@APCCV APCCV marked this pull request as ready for review November 7, 2024 15:34
@Neustradamus
Copy link

@APCCV: 23.05.x is always good, not EOL yet.

@APCCV APCCV force-pushed the netatalk branch 3 times, most recently from aa85032 to dfb8e5e Compare November 14, 2024 17:28
@APCCV
Copy link
Contributor Author

APCCV commented Nov 14, 2024

Took out last two commits enabling AppleTalk as more work is required to get it fully working. The previous 4 commits are solid and provide netatalk support for 23.05.

I get that servers are failing CI checks because they are being upgraded... any chance we can merge so this package becomes available in 23.05 while upgrades are in progress? These are 4 cherry-picked commits that build fine in 24.10 and snapshot.

@APCCV APCCV force-pushed the netatalk branch 2 times, most recently from b6fd331 to b4595c3 Compare November 18, 2024 17:40
APCCV and others added 4 commits November 22, 2024 19:53
Commit restores package after it was removed from OpenWrt 21.02.
Signed-off-by: Antonio Pastor <apccv@outlook.com>
Compile tested/run: ipq806x

No changes to package other than using latest available codebase.

Signed-off-by: Antonio Pastor <apccv@outlook.com>
Maintainer: Antonio Pastor / @APCCV
Compile tested: ipq806x (23.05.3, snapshot)
Run tested: ipq806x - C2600: start server, connect from MacOS, read/write files to home share, create/update TimeMachine backups

Description:
No changes to package other than using latest available upstream code base. Starting Netatalk 4.x build uses meson instead of autotools.

Signed-off-by: Antonio Pastor <antonio.pastor@gmail.com>
Updated title.
Updated description.
Reordered to match most common layout

Signed-off-by: Antonio Pastor <antonio.pastor@gmail.com>
@APCCV
Copy link
Contributor Author

APCCV commented Nov 23, 2024

There we go. All green.
It's not easy being green.

@Neustradamus
Copy link

@APCCV: Good job!
All the users community will be happy!

@APCCV
Copy link
Contributor Author

APCCV commented Nov 23, 2024

@Neustradamus Ha. Nobody but you and I have seen this PR yet. Don't get too excited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants