-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coova-chilli: fix defaults for redir and SSL #25850
base: master
Are you sure you want to change the base?
Conversation
10c4135
to
9114189
Compare
IIRC, |
@teslamint Thanks for your insight. Are you able to get the web redirection without the enabling the redir module? I tried but I do not get redirected at all. The minibrowser of the phone doesn't show up. |
That happened when chilli cannot see HTTP traffic from device or device cannot see response from chilli. Packet capture may help.
I don't see which case you need to chilli handles SSL traffic. |
Looking, thanks.
When the user posts their credentials on a login webpage, if the login page isn't served via HTTPS, the browser issues a security warning about the form not being secure. If the login page is served via HTTPS, then chilli needs to receive the GET/POST request on HTTPS, or otherwise the browser would also issue a big fat warning like the one shown below: Without SSL support, chilli is not able to respond on HTTPS. Moreover, even if SSL is enabled, it's not mandatory to configure it, if the user doesn't want it because maybe they're still in the playing stage, they can keep it turned off. |
Without HTTPS, browsers display security warnings, discouraging users and making the package impractical in modern environments. Updating this default setting will make the package published in the official OpenWrt feeds usable out of the box, lowering the barrier to entry for users exploring coova-chilli's hotspot features. Signed-off-by: Federico Capoano <f.capoano@openwisp.io>
9114189
to
8b494d9
Compare
I updated the patch to only change the default SSL setting. |
Indeed, if you try to send POST request from HTTPS web page to HTTP-only host, you get the warning. But, chilli supports GET request and most modern browsers has exception for local/private IP for security check, IIRC. |
Maintainer: @teslamint
Compile tested: (ramips, yuncore AX820, OpenWrt 24.10)
Run tested: (ramips, yuncore AX820, OpenWrt 24.10)
Description:
The current defaults in coova-chilli make the
package in the official OpenWrt repositories
nearly useless: it can't redirect users to
the login HTML page and doesn't support HTTPS.
Without HTTPS, browsers display security
warnings, discouraging users and making the
package impractical in modern environments.
Without redirects, the user would have to
open the login HTML page manually, which
is extremely bad UX.
Updating these defaults will make the package
published in the official OpenWrt feeds
usable out of the box, lowering the barrier
to entry for users exploring coova-chilli's
hotspot features.