Improve message buffer access #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we are not hax-typechecking ead*, so early returns are fine there.
geonnave
force-pushed
the
refactor-buffer-access
branch
from
c39304d to
780b8de
Compare
|
By the way, the MessageBuffer is at this point pretty much a re-implementation of heapless::Vec. If hacspec grows well, it may be possible to just swap that in at some point. (That'd work best when all direct access to content has been removed, which AIU we currently do for efficiency reasons -- thus, it may take some time until we can do that, for may require placement return). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.as_slice()instead ofbuffer.content[..buffer.len]fill_with_slice(slice)instead ofbuffer[..buffer.len].copy_from_slice(slice)This introduces some unwrap calls which should not fail, and I hope it could be guaranteed by hax. If not then it can be reworked.
Deliberately not being exhaustive in the calls to
.content[]within parsing routines. In this case, we also expect to have proofs from hax.