Updated to avro schema format. Added incremental lift based on format. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remental lift calculation.
jimee02
force-pushed
the
adding-incremental-lift
branch
from
842917e to
7035afd
Compare
modules/openxAnalyticsAdapter.js
Outdated
| function calculateIncrementalLift(bidRequests) { | ||
| let bidResponses = bidRequests.flatMap(bidRequest => bidRequest.bidResponses); | ||
| let [winningBidResponses, losingBidResponses] = partitionByWinningResponses(bidResponses); | ||
| let loserWithHigestCpm; |
There was a problem hiding this comment.
are they all guaranteed to be in USD ?
There was a problem hiding this comment.
also what happens if the second price comes from the same bidder ? or is it guaranteed that a bidder will only have one response ?
There was a problem hiding this comment.
oh good point. I'll leave it to you to do it :). I'll leave out the property in the payload.
kenan-gillet
approved these changes
May 28, 2020
bwschmidt
pushed a commit
that referenced
this pull request
Apr 5, 2022
* PBID-1541 Add the rest of the fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.