Trim axes to use the largest prefix that does not overlap with the best, instead of erasing. #225
+264
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_696936481
branch
2 times, most recently
from
486093f
to
b02a28f
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_696936481
branch
4 times, most recently
from
c67c405
to
7ae679b
Compare
…st, instead of erasing.
It avoids unnecessary full replications when a prefix of axes is not conflicting with the picked one. For example, if factor i is assigned to {"y":(4)2 }, then some other factor with a sharding {"x", "y", "z"} can now be assigned to {"x", "y":(1)4}.
PiperOrigin-RevId: 700705590
copybara-service
bot
force-pushed
the
test_696936481
branch
from
7ae679b
to
f718b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim axes to use the largest prefix that does not overlap with the best, instead of erasing.
It avoids unnecessary full replications when a prefix of axes is not conflicting with the picked one. For example, if factor i is assigned to {"y":(4)2 }, then some other factor with a sharding {"x", "y", "z"} can now be assigned to {"x", "y":(1)4}.