-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more ops in dot hoisting #14
base: llvm-head
Are you sure you want to change the base?
Conversation
The diff here includes changes that are made from exporting patches that we maintain. It's very hard to review the actual changes at the moment. Can you please rebase on top of the latest commit in llvm-head? Currently it is this one 3596dc5 |
Maybe best if you create PRs against the main branch. That way it will be easier to upstream. |
4ea1cf5
to
1a7940c
Compare
I've rebased the changes on the latest llvm-head branch. Rebasing onto main wasn't really possible, as these changes build on what is in llvm-head. |
The ops that are filtered in this code probably didn't work for a reason. A while back we added Select Op as it also faced problems when propagating the dot_op layout to the mask. I would expect that removing the Trunc Ops would require fixes to make them work. Did this "just work" after removing the condition? Ofc we will need test cases that cover this. Particularly lit tests showing the propagation when the Hoisting pattern activates. We also need to see that the tests lower correctly to LLVM. This might require an e2e test (or if it is already covered by an existing test we would require you to highlight that test/s). |
3596dc5
to
10d3305
Compare
Ops, seems that updates we have to maintain the Triton integration will cause PR diffs to break because of force-updates. We might need to figure out a better way to handle this as we didn't intend for this repo to accept incoming PRs. Apologies for this, but you will need to rebase again :\ |
1a7940c
to
8727650
Compare
da8895b
to
c8f89a6
Compare
Add support for hoisting dot layouts through
arith.truncf
,arith.trunci
andmath
ops.Note: I have some test cases (written as triton python examples) but wasn't sure whether you'd want these included in the PR. I am seeing a lot of test failures when running the triton tests on
llvm-head
with the openxla specific changes.