LHS Registers Part 2 - Pipelining #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
ggengnv
force-pushed
the
lhs-reg-pipeline
branch
from
3adec01
to
995c0b8
Compare
|
Addressed all comments in the original PR that are relevant to part 2 (one comment) in this PR instead. |
ggengnv
force-pushed
the
lhs-reg-pipeline
branch
2 times, most recently
from
b4d61b8
to
deefac7
Compare
Moerafaat
force-pushed
the
llvm-head
branch
from
3596dc5
to
10d3305
Compare
ggengnv
force-pushed
the
lhs-reg-pipeline
branch
from
deefac7
to
1cb92c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Part 1: #18)
Part 2 of "WGMMA with LHS operand in registers" feature.
Commits from
0f4faac"Initial changes for pipelining" onward are relevant to this part. The previous commits were for part 1.This PR enables SMEM pipelining for WGMMA operand A when it's in RF. It is necessary to add this change to those in part 1 to actually achieve better performance.