Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. #10510

Closed
wants to merge 1 commit into from
Closed

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes. #10510

wants to merge 1 commit into from

Conversation

zoranjovanovic-ns
Copy link
Contributor

First commit of the series for enabling Triton in XLA for ROCm .

@github-actions github-actions bot added the kokoro:force-run Forces CI to rerun label Mar 13, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Mar 13, 2024
@ddunl ddunl requested a review from tdanyluk March 13, 2024 20:32
tdanyluk
tdanyluk approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@tdanyluk tdanyluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you.

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 14, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
e84b339 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d
PiperOrigin-RevId: 615707894
@copybara-service copybara-service bot mentioned this pull request Mar 14, 2024
Closed
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 14, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
1a820a4 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d
PiperOrigin-RevId: 615707894
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 14, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
3ad5991 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend f680e98aa6908d02021bc0c8bb3d24edfc6b2a5d
PiperOrigin-RevId: 615707894
@i-chaochen
Copy link
Contributor

@tdanyluk we notice there is a conflict, but there is a PR from copybara-service to merge now. We wonder shall we resolve this conflict and rebase it again? which I think might need you to approve again?

@cheshire
Copy link
Member

Yes, could you re-base and I'll re-approve?

@github-actions github-actions bot added the kokoro:force-run Forces CI to rerun label Mar 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Mar 15, 2024
@zoranjovanovic-ns
Copy link
Contributor Author

Yes, could you re-base and I'll re-approve?

@cheshire rebased and pushed.

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 15, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
8ec002e 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 615707894
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 15, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
15e7ad4 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 615707894
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 15, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
1c697bb 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 615707894
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 15, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
1d25a9c 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 615707894
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 15, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
0ba4376 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 615707894
@zoranjovanovic-ns
Copy link
Contributor Author

@cheshire Do you know what is blocking PR from being merged?

copybara-service bot pushed a commit that referenced this pull request Mar 18, 2024
@zoranjovanovic-ns @copybara-github
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
ceee4bd 
…ed changes.

Imported from GitHub PR #10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d725 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=#10510 from ROCm:rocm_triton_backend 832d725
PiperOrigin-RevId: 616862111
@copybara-service copybara-service bot mentioned this pull request Mar 18, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 18, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
12bd258 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 616862111
@copybara-service copybara-service bot mentioned this pull request Mar 18, 2024
Closed
@tdanyluk
Copy link
Member

There are some internal failures, but nothing major, I'm trying to submit it.

copybara-service bot pushed a commit that referenced this pull request Mar 20, 2024
@zoranjovanovic-ns @copybara-github
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
759d9ed 
…ed changes.

Imported from GitHub PR #10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d725 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=#10510 from ROCm:rocm_triton_backend 832d725
PiperOrigin-RevId: 616862111
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 20, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
1437c8c 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10510 from ROCm:rocm_triton_backend 832d7253db1f8972862252f034b216d1eed1da29
PiperOrigin-RevId: 616862111
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 20, 2024
@zoranjovanovic-ns @tensorflower-gardener
PR #10510: [ROCm] Triton in XLA for ROCm - gemm rewriter triton relat…
982c126 
…ed changes.

Imported from GitHub PR openxla/xla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d7253db1f8972862252f034b216d1eed1da29 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes #10510

PiperOrigin-RevId: 617500238
@i-chaochen i-chaochen mentioned this pull request Apr 19, 2024
Closed
steeve pushed a commit to zml/xla that referenced this pull request Aug 30, 2024
@zoranjovanovic-ns @steeve
PR openxla#10510: [ROCm] Triton in XLA for ROCm - gemm rewriter trito…
6067312 
…n related changes.

Imported from GitHub PR openxla#10510

First commit of the series for enabling Triton in XLA for ROCm .
Copybara import of the project:

--
832d725 by Zoran Jovanovic <zjovanov@amd.com>:

[ROCm] Triton in XLA for ROCm - gemm rewriter triton related changes.

Merging this change closes openxla#10510

COPYBARA_INTEGRATE_REVIEW=openxla#10510 from ROCm:rocm_triton_backend 832d725
PiperOrigin-RevId: 617500238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheshire cheshire cheshire approved these changes

@tdanyluk tdanyluk tdanyluk approved these changes

Assignees

@xla-rotation xla-rotation

@kamaljeeti kamaljeeti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zoranjovanovic-ns @i-chaochen @cheshire @tdanyluk @kokoro-team @xla-rotation @kamaljeeti