[ROCm] Fix compilation issues related to aa08925e2dd1351c68e7838e074fe35908e3 #11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporarily remove ROCm Triton specific passes and include files until ROCm Triton is |
(Triton in XLA for ROCm - ir_emitter_triton related changes)
zoranjovanovic-ns
force-pushed
the
rocm_triton_fix_1
branch
from
82818f9
to
a4f80a3
Compare
zoranjovanovic-ns
changed the title
Closed
|
Hi @xla-rotation could you help us to review and merge this, please? as it's a missing caused by COPYBARA during aa08925 is merged |
golechwierowicz
approved these changes
Apr 10, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
…8e7838e074fe35908e3 Imported from GitHub PR openxla/xla#11331 Copybara import of the project: -- a4f80a3f32a10230bfdaa1dadc12f1f385883d8a by Zoran Jovanovic <zjovanov@amd.com>: Fix compilatio issues related to aa08925e2dd1351c68e7838e074fe35908e3ea07 (Triton in XLA for ROCm - ir_emitter_triton related changes) Merging this change closes #11331 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a PiperOrigin-RevId: 623459791
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
…8e7838e074fe35908e3 Imported from GitHub PR openxla/xla#11331 Copybara import of the project: -- a4f80a3f32a10230bfdaa1dadc12f1f385883d8a by Zoran Jovanovic <zjovanov@amd.com>: Fix compilatio issues related to aa08925e2dd1351c68e7838e074fe35908e3ea07 (Triton in XLA for ROCm - ir_emitter_triton related changes) Merging this change closes #11331 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a PiperOrigin-RevId: 623459791
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a PiperOrigin-RevId: 619652340
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
This was added as part of a prototype but no users appear to exist any more, and it was never a publicized API. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#11331 from ROCm:rocm_triton_fix_1 a4f80a3f32a10230bfdaa1dadc12f1f385883d8a PiperOrigin-RevId: 623274894
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Apr 10, 2024
…8e7838e074fe35908e3 Imported from GitHub PR openxla/xla#11331 Copybara import of the project: -- a4f80a3f32a10230bfdaa1dadc12f1f385883d8a by Zoran Jovanovic <zjovanov@amd.com>: Fix compilatio issues related to aa08925e2dd1351c68e7838e074fe35908e3ea07 (Triton in XLA for ROCm - ir_emitter_triton related changes) Merging this change closes #11331 PiperOrigin-RevId: 623476962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.