Fix: filter nil ip addr

openyurtio · Sep 20, 2022 · e414efe · e414efe
1 parent 98d7f5f
commit e414efe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/util/ip/ip.go b/pkg/util/ip/ip.go
@@ -72,7 +72,7 @@ func RemoveDupIPs(ips []net.IP) []net.IP {
 	results := make([]net.IP, 0, len(ips))
 	temp := map[string]bool{}
 	for _, ip := range ips {
-		if _, ok := temp[string(ip)]; !ok {
+		if _, ok := temp[string(ip)]; ip != nil && !ok {
 			temp[string(ip)] = true
 			results = append(results, ip)
 		}

diff --git a/pkg/util/ip/ip_test.go b/pkg/util/ip/ip_test.go
@@ -71,6 +71,11 @@ func TestRemoveDupIPs(t *testing.T) {
 			nil,
 			[]net.IP{},
 		},
+		{
+			"nil ip",
+			[]net.IP{[]byte("1.1.1.1"), nil},
+			[]net.IP{[]byte("1.1.1.1")},
+		},
 	}
 
 	for _, test := range tests {