You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What would you like to be added:
In each ObjectFilter(like masterservice, servicetopology, etc.), filter need to handle standalone object and List object. For example, masterservice filter need to handle *v1.ServiceList and *v1.Service as following:
And handling list object is just a collection of standalone object handling, so it is a good idea to handle list object in a common place like ResponseFilter instead of handling them in every ObjectFilter.
So i will make a pull request to improve list object handling in ObjectFilter, then ObjectFilter only need to handle standalone object(like *v1.Service).
others
/kind feature
The text was updated successfully, but these errors were encountered:
What would you like to be added:
In each ObjectFilter(like masterservice, servicetopology, etc.), filter need to handle standalone object and List object. For example,
masterservice
filter need to handle*v1.ServiceList
and*v1.Service
as following:openyurt/pkg/yurthub/filter/masterservice/filter.go
Lines 82 to 95 in acec197
And handling
list object
is just a collection of standalone object handling, so it is a good idea to handlelist object
in a common place likeResponseFilter
instead of handling them in everyObjectFilter
.So i will make a pull request to improve
list object
handling inObjectFilter
, thenObjectFilter
only need to handle standalone object(like *v1.Service).others
/kind feature
The text was updated successfully, but these errors were encountered: