Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move list object handling from ObjectFilter into ResponseFilter #1991

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Move list object handling in every ObjectFilter(like masterservice, servicetopology, etc.) into ResponseFilter, so each ObjectFilter only need to handle single object.

Which issue(s) this PR fixes:

Fixes #1990

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 53.04%. Comparing base (acec197) to head (41abd56).

Files Patch % Lines
pkg/yurthub/filter/responsefilter/filter.go 76.19% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
+ Coverage   52.90%   53.04%   +0.13%     
==========================================
  Files         176      176              
  Lines       20959    20929      -30     
==========================================
+ Hits        11089    11101      +12     
+ Misses       8918     8881      -37     
+ Partials      952      947       -5     
Flag Coverage Δ
unittests 53.04% <77.27%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@YTGhost YTGhost merged commit 43704c9 into openyurtio:master Mar 26, 2024
13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]extract list object handling from ObjectFilter to ResponseFilter
2 participants