Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add --feature-gate flag to yurt-controller-manager #212

Closed
DrmagicE opened this issue Jan 31, 2021 · 4 comments · Fixed by #222
Closed

[feature request] add --feature-gate flag to yurt-controller-manager #212

DrmagicE opened this issue Jan 31, 2021 · 4 comments · Fixed by #222
Assignees

Comments

@DrmagicE
Copy link
Member

Context
Hi, I deployed openyurt on a cluster with 2 nodes(1 master and 1 worker) to test the autonomy behaviour.
After setting-up yurt-controller-manager and yurt-hub, I stop the kubelet on the edge side.
The logs form yurt-controller-manager shows that the master is entering disruption mode, which is used to protect against master machine network isolation. It will prevent any evictions from happening if master can't see any healthy Node.

I0131 09:49:50.770911       1 node_lifecycle_controller.go:1230] Controller detected that all Nodes are not-Ready. Entering master disruption mode.

This is because my node name is ending with "master" and the lifecycle-controller will not take such node as a worker node:
https://github.com/alibaba/openyurt/blob/288aee566107ce7824669c59bb0b286074528293/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L1004-L1015
I can disable LegacyNodeRoleBehavior by adding feature-gates flags to kube-controller-manager.

feature-gates: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

...
spec:
  containers:
  - command:
    - kube-controller-manager
    - --allocate-node-cidrs=true
    - --feature-gates=LegacyNodeRoleBehavior=false <-- adding this line 
...

But the openyurt seems does not has such flag:

...
unknown flag: --feature-gates

What would you like to be added:
Add --feature-gates flag to yurt-controller-manager.

Why is this needed:
There should be a way to configure feature gates.

@rambohe-ch
Copy link
Member

@DrmagicE Thank you for filing issue to discuss --feature-gates.
I think that add --feature-gates for yurt-controller-manager is a good idea.
how about you? @Fei-Guo @kadisi

@Fei-Guo
Copy link
Member

Fei-Guo commented Feb 5, 2021

It sounds reasonable to me.

@rambohe-ch
Copy link
Member

@DrmagicE It looks like that you had dived into the implementation, would you take over this feature that add --feature-gates for yurt-controller-manager?

@DrmagicE
Copy link
Member Author

DrmagicE commented Feb 8, 2021

@rambohe-ch No problems. I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants