feat: Add --feature-gate flag to yurt-controller-manager #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Add
--feature-gates
flag to yurt-controller-manager.Reference:
https://github.com/kubernetes/kubernetes/blob/v1.16.15/cmd/kube-controller-manager/app/options/options.go#L251
Ⅱ. Does this pull request fix one issue?
fixes #212
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
step1
Start a 2 nodes Kubernetes cluster, name the master node as
master
and the worker node asworker
:Install and run
yurt-controller-manager
with the following--feature-gates
flags:step2
Stop the
kubelet
on the worker node.step3
Watch the output log of
yurt-controller-manager
and wait for theNodeNotReady
event to be observed by the controller. After observing the event, if there is not showing “Entering master disruption mode”, then the--feature-gates
is working as intended.Ⅴ. Special notes for reviews