Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --feature-gate flag to yurt-controller-manager #222

Merged
merged 1 commit into from
Feb 22, 2021
Merged

feat: Add --feature-gate flag to yurt-controller-manager #222

merged 1 commit into from
Feb 22, 2021

Conversation

DrmagicE
Copy link
Member

Ⅰ. Describe what this PR does

Add --feature-gates flag to yurt-controller-manager.

Reference:
https://github.com/kubernetes/kubernetes/blob/v1.16.15/cmd/kube-controller-manager/app/options/options.go#L251

Ⅱ. Does this pull request fix one issue?

fixes #212

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

step1
Start a 2 nodes Kubernetes cluster, name the master node as master and the worker node as worker:

$ kubectl get nodes
NAME     STATUS   ROLES    AGE   VERSION
master   Ready    master   30h   v1.16.15
worker   Ready    <none>   30h   v1.16.15

Install and run yurt-controller-manager with the following --feature-gates flags:

./yurt-controller-manager  --kubeconfig $your-kubeconfig --feature-gates=LegacyNodeRoleBehavior=false

step2
Stop the kubelet on the worker node.

step3
Watch the output log of yurt-controller-manager and wait for the NodeNotReady event to be observed by the controller. After observing the event, if there is not showing “Entering master disruption mode”, then the --feature-gates is working as intended.

Ⅴ. Special notes for reviews

Copy link
Member

@rambohe-ch rambohe-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rambohe-ch rambohe-ch merged commit 4d7463a into openyurtio:master Feb 22, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
feat: Add --feature-gate flag to yurt-controller-manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] add --feature-gate flag to yurt-controller-manager
2 participants