Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add command-line option for YurtHub to disable local cache and GC #476

Closed
DrmagicE opened this issue Sep 16, 2021 · 5 comments · Fixed by #483
Closed
Assignees
Labels
kind/feature kind/feature

Comments

@DrmagicE
Copy link
Member

DrmagicE commented Sep 16, 2021

What would you like to be added:
Add command-line option for YurtHub to disable local cache and GC.

Why is this needed:
Base on this discussion #450, the YurtHub should also be deployed on the cloud side.
When deploying on the cloud side, caching apiserver response and the garbage collector is no longer needed, so we should provides an option to disable them.

There are some reasonable options here:

  • --working-mode=cloud or
  • --disable-disk-cache=false
  • ..

Any advice?

others
/kind feature

@DrmagicE DrmagicE added the kind/feature kind/feature label Sep 16, 2021
@zzguang
Copy link
Member

zzguang commented Sep 16, 2021

In case that yurthub may extend other features for edge nodes in future, I think "--working-mode" is more reasonable.

@rambohe-ch
Copy link
Member

@DrmagicE It's make sense to me that add a new parameter for yurthub to specify where yurthub is working, edge or cloud.
--working-mode=cloud/edge (default value: edge) <-- agree +1

@rambohe-ch
Copy link
Member

By the way, besides gc and cache feature, other features like discardcloudservice filter, some request handler of yurthub can also be disabled. so --work-mode mode maybe more reasonable.

@DrmagicE
Copy link
Member Author

@rambohe-ch @zzguang Thanks for your advice. I think "--working-mode" is better. I will take over this issue.

@DrmagicE
Copy link
Member Author

/assign @DrmagicE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants