add zzguang as reviewer of OpenYurt #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
|
/assign @rambohe-ch @kadisi |
|
@zzguang welcome you to apply reviewer of OpenYurt. agree +1 |
|
Welcome @zzguang |
|
agree +1 |
1 similar comment
|
agree +1 |
|
+1 |
|
agree +1 |
|
@zzguang Congratulations on being a reviewer in the OpenYurt community. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, zzguang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MrGirl
pushed a commit
to MrGirl/openyurt
that referenced
this pull request
Mar 29, 2022
Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Username
@zzguang
Organization you are requesting membership in
openyurtio
Sponsors
@kadisi
Requirements
List of your contributions
PRs reviewed / authored:
proposal: add ingress feature support to nodepool #373
ingress: update nodepool ingress proposal #645
ingress: add nodepool endpoints filtering for nginx ingress controller #696
Add YurtIngress operator implementation #32
ingress: fix YurtIngress CR status update error #33
update README to add YurtAppDaemon and YurtIngress #34
ingress: update yurtingress tutorial link #37
ingress: add edge ingress md #48
ingress: update edge ingress md #72
Update architecture.md #73
[feature request] united-service among nodepools #390
Proposal: YurtAppDaemon #422
[Vote] About the naming of UnitedDaemonset #433
[feature request] Add command-line option for YurtHub to disable local cache and GC #476
[Question] What is the DNS best practice in the OpenYurt edge cluster? #515
Issues :
[Question] Does OpenYurt have a formal code style requirement? #330
[feature request] Yurthub data filtering framework optimization #699