proposal: add ingress feature support to nodepool #373
Conversation
Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
|
@zzguang: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @rambohe-ch |
|
/lgtm |
|
@zzguang Very appreciate for your proposal. and I am also agree with solution4. |
|
@zzguang the high level nodepool workload api cannot support customized configmaps in current stage, we might consider using one shared nginx config instead of customized configs among nodepools. |
| ```yaml | ||
| nodepool.openyurt.io/ingress-ips: "xxx" | ||
| ``` | ||
| - When it detects the NodePool annotation below is changed, it will update the corresponding configmap of the NodePool, |
There was a problem hiding this comment.
If the workloads in NodePool use different configmaps, NodePool daemonset resource need to support different configmap setting. so how about create different configmaps directly by user instead of setting NodePool ingress-config?
There was a problem hiding this comment.
About the details design for implementation, it's just a draft version by now. We will investigate more to make it clear.
Thanks for your suggestion, we will take it into account.
Okay, we can consider to use a global nginx config for all the nodepools, then we need to figure out 2 problems:
|
|
/approve and @zzguang will share this proposal in OpenYurt community meeting on July 21. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, zzguang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
Signed-off-by: zhenggu1 <zhengguang.zhang@intel.com>
Signed-off-by: zhenggu1 zhengguang.zhang@intel.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note