Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if error via ListKeys of Storage Interface. #1015

Merged

Conversation

fujitatomoya
Copy link
Contributor

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

/kind bug

What this PR does / why we need it:

Minor error check via LiseKeys of Storage Interface call.

Which issue(s) this PR fixes:

N.A (it just fixes debug log for user experience.)

Special notes for your reviewer:

I am not sure what kind of verification process or procedure required to this PR.
Could you provide the guidance about it?

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@openyurt-bot openyurt-bot added the kind/bug kind/bug label Sep 21, 2022
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1015 (73d644a) into master (db7ea27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   47.42%   47.42%           
=======================================
  Files          85       85           
  Lines       11791    11791           
=======================================
  Hits         5592     5592           
  Misses       5738     5738           
  Partials      461      461           
Flag Coverage Δ
unittests 47.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Congrool
Copy link
Member

lgtm, but seems e2e failed by accident, may need retest

@fujitatomoya
Copy link
Contributor Author

@Congrool can you kick the test on your side? not sure how to kick it though.

@Congrool
Copy link
Member

I also cannot trigger retest. But you can git commit --amend --no-edit --sign-off and push to github to trigger manually.

Copy link
Member

@Congrool Congrool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot openyurt-bot added the approved approved label Sep 22, 2022
@openyurt-bot openyurt-bot merged commit e4eb566 into openyurtio:master Sep 22, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fujitatomoya, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lorrielau pushed a commit to lorrielau/openyurt that referenced this pull request Sep 30, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants