improve data filter framework #1025
Conversation
|
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @yingjianjian @Congrool @zzguang |
|
@rambohe-ch: GitHub didn't allow me to assign the following users: yingjianjian, zzguang. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
+ Coverage 47.73% 48.17% +0.43%
==========================================
Files 95 95
Lines 13004 13010 +6
==========================================
+ Hits 6208 6267 +59
+ Misses 6263 6208 -55
- Partials 533 535 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/lgtm |
|
@yingjianjian: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
some little revisions are needed, otherwise LGTM |
rambohe-ch
force-pushed
the
improve-filter-framework
branch
from
0e3f691 to
7ba02a5
Compare
rambohe-ch
force-pushed
the
improve-filter-framework
branch
from
7ba02a5 to
916ddd6
Compare
|
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does:
improve data filter setting format in configmap
kube-system/yurthub-cfgin order to leverage end users configure filter setting conveniently.take servicetopology filter as an example:
original setting
filter_servicetopology: "user-agent1/resource#verb1;verb2, user-agent2/resource#verb1;verb2"
improved setting
servicetopology: "user-agent1, user-agent2"
by the way, the original setting format is also supported in order to keep consistency.
Why we need it:
because which resource and verbs of requests are supported is fixed by filter, for example,
servicetopologyfilter can only support requests witch list/watch endpoints and endpointslices. so it's no need for end users to configure info of resource and verbs.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note