add inclusterconfig filter for commenting kube-proxy configmap #1158
Conversation
|
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
+ Coverage 55.59% 55.63% +0.03%
==========================================
Files 98 100 +2
Lines 12881 12910 +29
==========================================
+ Hits 7161 7182 +21
- Misses 5091 5102 +11
+ Partials 629 626 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| if err := ki.ConfigureKubeProxyAddon(); err != nil { | ||
| return err | ||
| } | ||
| //if err := ki.ConfigureKubeProxyAddon(); err != nil { |
There was a problem hiding this comment.
I guess this function should be deleted.
rambohe-ch
force-pushed
the
add-filter
branch
from
6106e09 to
a5cbc88
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
add inclusterconfig filter for commenting kubeconfig setting in
kube-system/kube-proxyconfigmap, in order to make kube-proxy on nodes with yurthub(like edge nodes) to useInClusterConfigto access kube-apiserver. at the same time, kube-proxy on master nodes without yurthub can use kubeconfig to access kube-apiserver.delete kube-proxy configure in
yurtctl init testcommand.Which issue(s) this PR fixes:
Fixes #1127
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note