Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pool-coordinator cannot be rescheduled when its node fails (#1212) #1218

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

AndyEWang
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

when the node disconnects from all nodes except itself, pool-coordinator in this node can be rescheduled into a healthy node.

Which issue(s) this PR fixes:

Fixes #1212

Special notes for your reviewer:

/assign @rambohe-ch
/assign @Congrool

Does this PR introduce a user-facing change?

Since charts/openyurt/templates/pool-coordinator.yaml is changed, users should upgrade the running pool-coordinator.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1218 (08d8d74) into master (c524116) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage   52.35%   52.33%   -0.02%     
==========================================
  Files         106      106              
  Lines       13852    13852              
==========================================
- Hits         7252     7250       -2     
- Misses       5952     5953       +1     
- Partials      648      649       +1     
Flag Coverage Δ
unittests 52.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/iptables/iptables.go 87.12% <0.00%> (-0.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyEWang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Feb 9, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Feb 10, 2023
@openyurt-bot openyurt-bot merged commit 7d00539 into openyurtio:master Feb 10, 2023
@rambohe-ch rambohe-ch added the backport release-v1.2 backport release-v1.2 label Feb 17, 2023
@rambohe-ch
Copy link
Member

/backport release-v1.2

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.2 backport release-v1.2 lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] pool-coordinator isn't rescheduled when its node disconnects from others
4 participants