-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate controller poolcoordinatorcert #1336
Conversation
@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a633624
to
3813716
Compare
You have successfully added a new Trivy configuration |
You have successfully added a new Trivy configuration |
You have successfully added a new Trivy configuration |
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
+ Coverage 52.96% 53.10% +0.14%
==========================================
Files 102 103 +1
Lines 12849 12879 +30
==========================================
+ Hits 6805 6839 +34
+ Misses 5486 5482 -4
Partials 558 558
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pkg/controller/poolcoordinator/cert/poolcoordinatorcert_controller.go
Outdated
Show resolved
Hide resolved
3813716
to
bf451d9
Compare
bf451d9
to
c6c6c68
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luc99hen, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #1067
Special notes for your reviewer:
Does this PR introduce a user-facing change?