Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate controller poolcoordinatorcert #1336

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

luc99hen
Copy link
Member

@luc99hen luc99hen commented Mar 28, 2023

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  1. migrate poolcoordinator-cert-manager into yurt-manager framework
  2. fix syntax in helm charts

Which issue(s) this PR fixes:

Fixes # #1067

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@openyurt-bot
Copy link
Collaborator

@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

  1. migrate poolcoordinator-cert-manager into yurt-manager framework
  2. fix syntax in helm charts

Which issue(s) this PR fixes:

Fixes # #1067

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Mar 28, 2023
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Mar 28, 2023
@luc99hen luc99hen force-pushed the controller-migrate branch from a633624 to 3813716 Compare March 28, 2023 08:18
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurthub. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:yurt-manager. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images/target:node-servant. As part of the setup process, we have scanned this repository and found 2 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1336 (c6c6c68) into master (384238f) will increase coverage by 0.14%.
The diff coverage is 25.49%.

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
+ Coverage   52.96%   53.10%   +0.14%     
==========================================
  Files         102      103       +1     
  Lines       12849    12879      +30     
==========================================
+ Hits         6805     6839      +34     
+ Misses       5486     5482       -4     
  Partials      558      558              
Flag Coverage Δ
unittests 53.10% <25.49%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/poolcoordinator/cert/util.go 42.42% <0.00%> (ø)
...coordinator/cert/poolcoordinatorcert_controller.go 16.37% <17.50%> (ø)
pkg/controller/poolcoordinator/cert/certificate.go 49.83% <57.14%> (ø)
pkg/controller/poolcoordinator/cert/secret.go 75.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@luc99hen Maybe you can use injector to prepare kubernetes.Interface, and you reference the injector in this pr: #1334

@luc99hen luc99hen force-pushed the controller-migrate branch from 3813716 to bf451d9 Compare March 29, 2023 13:11
@luc99hen luc99hen force-pushed the controller-migrate branch from bf451d9 to c6c6c68 Compare March 29, 2023 13:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luc99hen, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Mar 30, 2023
@openyurt-bot openyurt-bot merged commit eafe3c0 into openyurtio:master Mar 30, 2023
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants