Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak for yur-tunnel-server #1471

Merged

Conversation

huweihuang
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

There is a memory leak in the yurt-tunnel-server, consuming too much memory.

The reason is that there is a goroutine memory leak in the dependency apiserver-network-proxy

Which issue(s) this PR fixes:

Fixes # #1440

Special notes for your reviewer:

@rambohe-ch

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #1471 (453c87a) into master (505c27a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
- Coverage   50.74%   50.73%   -0.02%     
==========================================
  Files         131      131              
  Lines       15576    15576              
==========================================
- Hits         7904     7902       -2     
- Misses       6951     6952       +1     
- Partials      721      722       +1     
Flag Coverage Δ
unittests 50.73% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@rambohe-ch
Copy link
Member

@huweihuang please fix verify ci errors. maybe you need execute command go mod tidy before git push.

@huweihuang huweihuang force-pushed the fix-memory-leak-for-tunnel-server branch from 32b8526 to 453c87a Compare May 21, 2023 03:46
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huweihuang, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label May 23, 2023
@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

Fixes #1440

@rambohe-ch
Copy link
Member

/backport release-v1.3

@github-actions
Copy link

Successfully created backport PR for release-v1.3:

JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.3 backport release-v1.3 lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants