-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support SIGUSR1 signal for yurthub #1487
Conversation
Signed-off-by: ricky <yricky509@gmail.com>
@y-ykcir: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
- Coverage 50.74% 50.43% -0.31%
==========================================
Files 131 133 +2
Lines 15576 15818 +242
==========================================
+ Hits 7904 7978 +74
- Misses 6951 7107 +156
- Partials 721 733 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: ricky <yricky509@gmail.com>
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, y-ykcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* feat: support SIGUSR1 signal for yurthub Signed-off-by: ricky <yricky509@gmail.com> * set output directory for log Signed-off-by: ricky <yricky509@gmail.com> --------- Signed-off-by: ricky <yricky509@gmail.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1475
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note