Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move iot controller to yurt-manager #1488

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

Rui-Gan
Copy link
Member

@Rui-Gan Rui-Gan commented May 23, 2023

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1067

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Rui-Gan: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1067

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1488 (5a01a2f) into master (c3cf90b) will not change coverage.
The diff coverage is n/a.

❗ Current head 5a01a2f differs from pull request most recent head 13023d9. Consider uploading reports for the commit 13023d9 to get more accurate results

@@           Coverage Diff           @@
##           master    #1488   +/-   ##
=======================================
  Coverage   50.85%   50.85%           
=======================================
  Files         133      133           
  Lines       15852    15852           
=======================================
  Hits         8062     8062           
  Misses       7045     7045           
  Partials      745      745           
Flag Coverage Δ
unittests 50.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rui-Gan and others added 2 commits June 13, 2023 14:42
Signed-off-by: Rui-Gan <1171530954@qq.com>

add a new crd device/v1alpha1&v1alpha2/iot and controller, webhook

Signed-off-by: Rui-Gan <1171530954@qq.com>
…t group

Signed-off-by: LavenderQAQ <1254297317@qq.com>
@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LavenderQAQ
Copy link
Member

/assign @Rui-Gan

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 19, 2023
@openyurt-bot openyurt-bot merged commit b2d7d49 into openyurtio:master Jun 19, 2023
13 checks passed
@LavenderQAQ LavenderQAQ deleted the iot branch June 19, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feature request]move scattered controllers into yurt-manager
4 participants