Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use real kubernetes server address to yurthub when yurtadm join #1517

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

Lan-ce-lot
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

In the scenario where the user forgets to set the yurthub server address for the master node, the yurtadm join command should replace the yurthub parameter with the address obtained from the join.

Which issue(s) this PR fixes:

Fixes #
#1474

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Lan-ce-lot: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

In the scenario where the user forgets to set the yurthub server address for the master node, the yurtadm join command should replace the yurthub parameter with the address obtained from the join.

Which issue(s) this PR fixes:

Fixes #
#1474

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1517 (8f92b63) into master (b99c905) will decrease coverage by 0.36%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   50.74%   50.38%   -0.36%     
==========================================
  Files         131      132       +1     
  Lines       15576    15707     +131     
==========================================
+ Hits         7904     7914      +10     
- Misses       6951     7070     +119     
- Partials      721      723       +2     
Flag Coverage Δ
unittests 50.38% <60.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurtadm/util/yurthub/yurthub.go 9.16% <60.00%> (ø)

... and 1 file with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lan-ce-lot, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 6, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jun 6, 2023
@openyurt-bot openyurt-bot merged commit 68893e4 into openyurtio:master Jun 6, 2023
13 checks passed
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants