fix: yurtadm support enable kubelet service

[YTGhost]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1520

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?

other Note

[openyurt-bot]

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1520

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1523 (f2f2971) into master (68893e4) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f2f2971 differs from pull request most recent head d0d1a31. Consider uploading reports for the commit d0d1a31 to get more accurate results

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   50.39%   50.42%   +0.02%     
==========================================
  Files         132      132              
  Lines       15707    15783      +76     
==========================================
+ Hits         7916     7958      +42     
- Misses       7069     7094      +25     
- Partials      722      731       +9     

Flag	Coverage Δ
unittests	50.42% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

[rambohe-ch]

@huiwq1990 PTAL

[huiwq1990]

@YTGhost
It should call enable kubelet after yurtadmutil.SetKubeletService().

func RunPrepare(data joindata.YurtJoinData) error {
	// cleanup at first
	staticPodsPath := filepath.Join(constants.KubeletConfigureDir, constants.ManifestsSubDirName)
	if err := os.RemoveAll(staticPodsPath); err != nil {
		klog.Warningf("remove %s: %v", staticPodsPath, err)
	}

	if err := system.SetIpv4Forward(); err != nil {
		return err
	}
	if err := system.SetBridgeSetting(); err != nil {
		return err
	}
	if err := system.SetSELinux(); err != nil {
		return err
	}
	if err := yurtadmutil.CheckAndInstallKubelet(data.KubernetesResourceServer(), data.KubernetesVersion()); err != nil {
		return err
	}
	if err := yurtadmutil.CheckAndInstallKubeadm(data.KubernetesResourceServer(), data.KubernetesVersion()); err != nil {
		return err
	}
	if err := yurtadmutil.CheckAndInstallKubernetesCni(data.ReuseCNIBin()); err != nil {
		return err
	}
	if err := yurtadmutil.SetKubeletService(); err != nil {
		return err
	}

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[YTGhost]

@YTGhost It should call enable kubelet after yurtadmutil.SetKubeletService().

func RunPrepare(data joindata.YurtJoinData) error {
	// cleanup at first
	staticPodsPath := filepath.Join(constants.KubeletConfigureDir, constants.ManifestsSubDirName)
	if err := os.RemoveAll(staticPodsPath); err != nil {
		klog.Warningf("remove %s: %v", staticPodsPath, err)
	}

	if err := system.SetIpv4Forward(); err != nil {
		return err
	}
	if err := system.SetBridgeSetting(); err != nil {
		return err
	}
	if err := system.SetSELinux(); err != nil {
		return err
	}
	if err := yurtadmutil.CheckAndInstallKubelet(data.KubernetesResourceServer(), data.KubernetesVersion()); err != nil {
		return err
	}
	if err := yurtadmutil.CheckAndInstallKubeadm(data.KubernetesResourceServer(), data.KubernetesVersion()); err != nil {
		return err
	}
	if err := yurtadmutil.CheckAndInstallKubernetesCni(data.ReuseCNIBin()); err != nil {
		return err
	}
	if err := yurtadmutil.SetKubeletService(); err != nil {
		return err
	}

@huiwq1990 Yes, I made a mistake, and now it has been revised

[huiwq1990]

/lgtm

[openyurt-bot]

@huiwq1990: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openyurt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rambohe-ch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rambohe-ch]

/lgtm