Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pool-coordinator to yurt-coordinator for controller #1531

Conversation

JameKeal
Copy link
Member

@JameKeal JameKeal commented Jun 8, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Unify the naming rules of each component in openyurtio/openyurt repo, it is more understandable for end users.

Which issue(s) this PR fixes:

Fixes #1482

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Unify the naming rules of each component in openyurtio/openyurt repo, it is more understandable for end users.

Which issue(s) this PR fixes:

Fixes #1482

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Jun 8, 2023
@openyurt-bot openyurt-bot requested review from DrmagicE and qclc June 8, 2023 11:19
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1531 (e04c829) into master (2ddaf25) will not change coverage.
The diff coverage is 25.39%.

❗ Current head e04c829 differs from pull request most recent head e6b5522. Consider uploading reports for the commit e6b5522 to get more accurate results

@@           Coverage Diff           @@
##           master    #1531   +/-   ##
=======================================
  Coverage   50.51%   50.51%           
=======================================
  Files         133      133           
  Lines       15819    15819           
=======================================
  Hits         7991     7991           
  Misses       7096     7096           
  Partials      732      732           
Flag Coverage Δ
unittests 50.51% <25.39%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/yurtcoordinator/cert/secret.go 75.00% <ø> (ø)
...rdinator/delegatelease/delegatelease_controller.go 22.48% <ø> (ø)
pkg/controller/yurtcoordinator/utils/lease.go 100.00% <ø> (ø)
pkg/controller/yurtcoordinator/utils/taints.go 100.00% <ø> (ø)
...coordinator/cert/yurtcoordinatorcert_controller.go 11.94% <8.69%> (ø)
pkg/controller/yurtcoordinator/cert/certificate.go 49.16% <54.54%> (ø)
...g/controller/csrapprover/csrapprover_controller.go 26.84% <100.00%> (ø)
pkg/controller/yurtcoordinator/cert/util.go 87.50% <100.00%> (ø)

@JameKeal JameKeal force-pushed the rename-poolcoordinator-to-yurtcoordinator-for-controller branch from e04c829 to e6b5522 Compare June 8, 2023 12:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Jun 9, 2023
@openyurt-bot openyurt-bot merged commit dede3c9 into openyurtio:master Jun 9, 2023
@JameKeal JameKeal deleted the rename-poolcoordinator-to-yurtcoordinator-for-controller branch June 9, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]how about rename pool-coordinator to yurt-coordinator
3 participants