Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pool-coordinator to yurt-coordinator for charts #1551

Conversation

JameKeal
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Unify the naming rules of each component in openyurtio/openyurt repo, it is more understandable for end users.

Which issue(s) this PR fixes:

Fixes #1482

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Unify the naming rules of each component in openyurtio/openyurt repo, it is more understandable for end users.

Which issue(s) this PR fixes:

Fixes #1482

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jun 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #1551 (8e4e433) into master (c3cf90b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1551   +/-   ##
=======================================
  Coverage   50.85%   50.85%           
=======================================
  Files         133      133           
  Lines       15852    15852           
=======================================
  Hits         8062     8062           
  Misses       7045     7045           
  Partials      745      745           
Flag Coverage Δ
unittests 50.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added approved approved lgtm lgtm labels Jun 18, 2023
@openyurt-bot openyurt-bot merged commit 94243d5 into openyurtio:master Jun 18, 2023
13 checks passed
@JameKeal JameKeal deleted the rename-poolcoordinator-to-yurt-coordinator-for-charts branch June 20, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]how about rename pool-coordinator to yurt-coordinator
3 participants