Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: added github registry #1578

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

siredmar
Copy link
Contributor

@siredmar siredmar commented Jul 3, 2023

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Adds support for pushing to github container registry to avoid docker hub rate limits.

Which issue(s) this PR fixes:

Fixes #1575

Special notes for your reviewer:

Does this PR introduce a user-facing change?

OCI images can now also be found on Github

other Note

@openyurt-bot
Copy link
Collaborator

@siredmar: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Adds support for pushing to github container registry to avoid docker hub rate limits.

Which issue(s) this PR fixes:

Fixes #1575

Special notes for your reviewer:

Does this PR introduce a user-facing change?

OCI images can now also be found on Github

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Jul 3, 2023
@openyurt-bot
Copy link
Collaborator

Welcome @siredmar! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Jul 3, 2023
@siredmar
Copy link
Contributor Author

siredmar commented Jul 3, 2023

@rambohe-ch you need to provide two repository secrets called
GITHUB_REGISTRY_USERNAME and GITHUB_REGISTRY_USERNAME containing the username that pushes and a PAT (private access token) from github described in the following docs: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

@rambohe-ch
Copy link
Member

@rambohe-ch you need to provide two repository secrets called GITHUB_REGISTRY_USERNAME and GITHUB_REGISTRY_USERNAME containing the username that pushes and a PAT (private access token) from github described in the following docs: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

@siredmar Very appreciate for your pull request. Because secrets are allowed start with GITHUB_, so i have created two secrets named as GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD, please update your pull request with these two secrets.

@rambohe-ch
Copy link
Member

@siredmar please fix the conflicting files. and the changes in this pull request should be merged into registry.yaml.

Signed-off-by: Armin Schlegel <armin.schlegel@gmx.de>

 wip
@siredmar
Copy link
Contributor Author

siredmar commented Jul 4, 2023

@rambohe-ch done

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1578 (915c0c5) into master (41647c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1578   +/-   ##
=======================================
  Coverage   51.43%   51.43%           
=======================================
  Files         134      134           
  Lines       15947    15947           
=======================================
  Hits         8202     8202           
  Misses       7000     7000           
  Partials      745      745           
Flag Coverage Δ
unittests 51.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, siredmar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the approved approved label Jul 5, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 5, 2023
@rambohe-ch rambohe-ch merged commit 6a22238 into openyurtio:master Jul 5, 2023
13 checks passed
@siredmar siredmar deleted the github_registry branch July 5, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider github container registry
3 participants