Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support edgex minnesota through auto-collector #1582

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

LavenderQAQ
Copy link
Member

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

support edgex minnesota through auto-collector

Which issue(s) this PR fixes:

Fixes #1581

other Note

I'm just a porter representing the auto-collector🤣

Signed-off-by: LavenderQAQ <1254297317@qq.com>
@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: GitHub didn't allow me to assign the following users: Rui-Gan.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Rui-Gan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LavenderQAQ
Copy link
Member Author

Hold on, this is an automatically generated configuration, we still need to do some reviews on this edgex version🧐.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #1582 (02190f9) into master (c730e64) will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   51.01%   51.43%   +0.41%     
==========================================
  Files         133      134       +1     
  Lines       15758    15947     +189     
==========================================
+ Hits         8039     8202     +163     
- Misses       6983     7000      +17     
- Partials      736      745       +9     
Flag Coverage Δ
unittests 51.43% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

@LavenderQAQ LavenderQAQ force-pushed the feat/edgex-minnesota branch 3 times, most recently from 2baf520 to b856134 Compare July 5, 2023 02:21
Signed-off-by: LavenderQAQ <1254297317@qq.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Rui-Gan
Copy link
Member

Rui-Gan commented Jul 5, 2023

/lgtm

@openyurt-bot
Copy link
Collaborator

@Rui-Gan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rui-Gan
Copy link
Member

Rui-Gan commented Jul 5, 2023

/approve

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jul 6, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 6, 2023
@openyurt-bot openyurt-bot merged commit 9a97791 into openyurtio:master Jul 6, 2023
13 checks passed
@LavenderQAQ LavenderQAQ deleted the feat/edgex-minnesota branch August 11, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] support edgex minnesota through auto-collector
4 participants