Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide users with the ability to customize the edgex framework #1596

Merged

Conversation

LavenderQAQ
Copy link
Member

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

This pr will give users the ability to customize the edgex framework. We write the standard configuration collected by the auto-collector into a configmap called "platformadmin-framework". Users can customize their edgex by editing this configmap.

Which issue(s) this PR fixes:

Fixes #1595

Special notes for your reviewer:

Does this PR introduce a user-facing change?

# Support for customizing edgex configurations by modifying configmap
kubectl edit cm platformadmin-framework

other Note

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature
/sig iot

What this PR does / why we need it:

This pr will give users the ability to customize the edgex framework. We write the standard configuration collected by the auto-collector into a configmap called "platformadmin-framework". Users can customize their edgex by editing this configmap.

Which issue(s) this PR fixes:

Fixes #1595

Special notes for your reviewer:

Does this PR introduce a user-facing change?

# Support for customizing edgex configurations by modifying configmap
kubectl edit cm platformadmin-framework

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1596 (9e8ae40) into master (d9f74ab) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
- Coverage   51.43%   51.35%   -0.08%     
==========================================
  Files         134      134              
  Lines       15947    15947              
==========================================
- Hits         8202     8190      -12     
- Misses       7000     7011      +11     
- Partials      745      746       +1     
Flag Coverage Δ
unittests 51.35% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@LavenderQAQ
Copy link
Member Author

At present, the isolation of PlatformAdmin is not enough. It can only be configured on a namespace basis. When two edgex versions appear in a namespace, overwriting problems may occur. For this problem we need to combine #1435 to solve.

@LavenderQAQ LavenderQAQ force-pushed the feat/iot-customization-temporary branch from b9f9fe6 to 204bdb1 Compare July 10, 2023 07:55
@LavenderQAQ
Copy link
Member Author

/assign @Rui-Gan

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: GitHub didn't allow me to assign the following users: Rui-Gan.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Rui-Gan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LavenderQAQ LavenderQAQ force-pushed the feat/iot-customization-temporary branch from 204bdb1 to b1ac0ac Compare July 12, 2023 01:58
Signed-off-by: LavenderQAQ <1254297317@qq.com>
@LavenderQAQ LavenderQAQ force-pushed the feat/iot-customization-temporary branch from b1ac0ac to dca9244 Compare July 12, 2023 02:35
@openyurt-bot
Copy link
Collaborator

@Rui-Gan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: LavenderQAQ <1254297317@qq.com>
@LavenderQAQ LavenderQAQ force-pushed the feat/iot-customization-temporary branch from dca9244 to 9e8ae40 Compare July 13, 2023 02:25
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Rui-Gan
Copy link
Member

Rui-Gan commented Jul 14, 2023

/assign

@Rui-Gan
Copy link
Member

Rui-Gan commented Jul 14, 2023

/lgtm

@openyurt-bot
Copy link
Collaborator

@Rui-Gan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added lgtm lgtm approved approved labels Jul 17, 2023
@openyurt-bot openyurt-bot merged commit 5605022 into openyurtio:master Jul 17, 2023
13 of 14 checks passed
@LavenderQAQ LavenderQAQ deleted the feat/iot-customization-temporary branch August 11, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Provide users with the ability to customize the edgex framework
4 participants