Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Multi-region workloads configuration rendering engine #1600

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1435

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@vie-serendipity: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1435

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1600 (edbbea0) into master (d15078f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1600   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files         154      154           
  Lines       17637    17637           
=======================================
  Hits         9228     9228           
  Misses       7582     7582           
  Partials      827      827           
Flag Coverage Δ
unittests 52.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vie-serendipity vie-serendipity deleted the proposal4yurtappconfigurationreplacement branch August 1, 2023 08:19
@vie-serendipity vie-serendipity restored the proposal4yurtappconfigurationreplacement branch August 1, 2023 08:19
docs/proposals/20230706-yurtappoverrider.md Show resolved Hide resolved
docs/proposals/20230706-yurtappoverrider.md Outdated Show resolved Hide resolved
docs/proposals/20230706-yurtappoverrider.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, vie-serendipity

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, vie-serendipity

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 22, 2023
@openyurt-bot openyurt-bot merged commit f1262a6 into openyurtio:master Aug 22, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: configuration rendering engine for multi-regions
7 participants