Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new gateway version v1beta1 #1641

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Aug 9, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement
/sig network

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement
/sig network

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1641 (4deb4d9) into master (237fe8f) will increase coverage by 0.65%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head 4deb4d9 differs from pull request most recent head ea84f27. Consider uploading reports for the commit ea84f27 to get more accurate results

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
+ Coverage   50.93%   51.59%   +0.65%     
==========================================
  Files         137      145       +8     
  Lines       16029    17011     +982     
==========================================
+ Hits         8164     8776     +612     
- Misses       7126     7418     +292     
- Partials      739      817      +78     
Flag Coverage Δ
unittests 51.59% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

go.mod Outdated Show resolved Hide resolved
pkg/webhook/server.go Outdated Show resolved Hide resolved
@River-sh River-sh force-pushed the dev_update_gateway_api branch 5 times, most recently from 41aeab4 to d987528 Compare August 9, 2023 13:53
@River-sh River-sh force-pushed the dev_update_gateway_api branch 7 times, most recently from 5e41281 to 59008c7 Compare August 10, 2023 15:53
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BSWANG, rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 11, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 11, 2023
@openyurt-bot openyurt-bot merged commit 3595932 into openyurtio:master Aug 11, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants